Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run allocation at t = 0 #1389

Closed
visr opened this issue Apr 15, 2024 · 1 comment · Fixed by #1496
Closed

Run allocation at t = 0 #1389

visr opened this issue Apr 15, 2024 · 1 comment · Fixed by #1496
Labels
allocation Allocation layer core Issues related to the computational core in Julia

Comments

@visr
Copy link
Member

visr commented Apr 15, 2024

Currently allocation doesn't run at t = 0. This is done because flow on the source edges is still unknown. This means that effectively there is a free-for-all situation for the allocation interval. It would be better to special case t = 0, to run the RHS once to get a first estimate for the instantaneous flows at t = 0, and then run allocation with that.

@visr visr added allocation Allocation layer core Issues related to the computational core in Julia improvement labels Apr 15, 2024
@github-project-automation github-project-automation bot moved this to To do in Ribasim Apr 15, 2024
@SouthEndMusic
Copy link
Collaborator

SouthEndMusic commented Apr 24, 2024

With #1427 it is required to set these initial instantaneous flows* as the mean flows.

.* To be precise, set the instantaneous flows times the allocation interval as the mean flows, as there is a division by the allocation interval at the start of update_allocation!.

@SnippenE SnippenE moved this from To do to What's next in Ribasim May 16, 2024
@SnippenE SnippenE moved this from What's next to Sprint backlog in Ribasim May 16, 2024
@SouthEndMusic SouthEndMusic moved this from Sprint backlog to 🏗 In progress in Ribasim May 22, 2024
@SouthEndMusic SouthEndMusic moved this from 🏗 In progress to 👀 In review in Ribasim May 22, 2024
visr pushed a commit that referenced this issue May 23, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Ribasim May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
allocation Allocation layer core Issues related to the computational core in Julia
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants