Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do all TeamCity checks on version bump PRs #1404

Closed
visr opened this issue Apr 18, 2024 · 0 comments · Fixed by #1411
Closed

Do all TeamCity checks on version bump PRs #1404

visr opened this issue Apr 18, 2024 · 0 comments · Fixed by #1411
Assignees
@Jingru923
Labels
CI/CD Continuous Integration/Continuous deployment

Comments

@visr
Copy link
Member

visr commented Apr 18, 2024

To avoid partially broken releases, we should update our release process and TeamCity configuration. If we require version bump PRs to have branch names that start with release, we can add a trigger in TeamCity to run the libribasim and CLI tests. Then we should wait until those are successful before merging the PR.

Came up in #1403 (comment)
@github-project-automation github-project-automation bot moved this to To do in Ribasim Apr 18, 2024
@visr visr added the CI/CD Continuous Integration/Continuous deployment label Apr 18, 2024
@Jingru923 Jingru923 assigned Jingru923 and unassigned Jingru923 Apr 22, 2024
@Jingru923 Jingru923 moved this from To do to 🏗 In progress in Ribasim Apr 22, 2024
@Jingru923 Jingru923 mentioned this issue Apr 22, 2024
Closed
@Jingru923 Jingru923 linked a pull request Apr 22, 2024 that will close this issue
release-2022-2-2 #1409
Closed
@Jingru923 Jingru923 mentioned this issue Apr 22, 2024
Merged
Jingru923 added a commit that referenced this issue Apr 22, 2024
@Jingru923
only release if branch stars with v20 (#1411)
46937dd 
Fixes #1404
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Ribasim Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jingru923 Jingru923

Labels
CI/CD Continuous Integration/Continuous deployment
Projects
Ribasim
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

only release if branch stars with v20 Deltares/Ribasim
release-2022-2-2 Deltares/Ribasim
2 participants
@visr @Jingru923