Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allocation test failure on main #1423

Closed
visr opened this issue Apr 23, 2024 · 2 comments · Fixed by #1424
Closed

Allocation test failure on main #1423

visr opened this issue Apr 23, 2024 · 2 comments · Fixed by #1424
Labels
allocation Allocation layer test Relates to unit testing

Comments

@visr
Copy link
Member

visr commented Apr 23, 2024 •
edited
Loading

This test failure shows up sometimes. Possibly since #1399.

No Captured Logs for test item "Allocation level control" at test\allocation_test.jl:308 on worker 7960
Error in testset "Allocation level control" on worker 7960:
Test Failed at D:\a\Ribasim\Ribasim\core\test\allocation_test.jl:364
  Expression: ≈(storage[stage_5], u_stage_5.(t[stage_5]), rtol = 0.0001)
   Evaluated: [1654.8209307353425, 1611.6209217322994, 1596.0102056697474] ≈ [1654.8209307353425, 1611.6209307353424, 1568.4209307353424] (rtol=0.0001)

Error in testset "Allocation level control" on worker 7960:
Test Failed at D:\a\Ribasim\Ribasim\core\test\allocation_test.jl:[372](https://github.com/Deltares/Ribasim/actions/runs/8802274133/job/24157582821#step:6:373)
  Expression: ≈(storage[stage_6], u_stage_6.(t[stage_6]), rtol = 0.0001)
   Evaluated: [1533.1275614894184, 1499.9856889683385, 1499.9856107363594, 1499.985610656249, 1499.985610653905, 1499.9856106538211, 1499.9856106538184, 1499.9856106538184, 1499.9856106538184, 1499.9856106538184, 1499.9856106538193] ≈ [1533.1275614894184, 1533.1275614894184, 1533.1275614894184, 1533.1275614894184, 1533.1275614894184, 1533.1275614894184, 1533.1275614894184, 1533.1275614894184, 1533.1275614894184, 1533.1275614894184, 1533.1275614894184] (rtol=0.0001)

In table form:

evaluated expected difference
1654.820931 1654.820931 0
1611.620922 1611.620931 -9E-06
1596.010206 1568.420931 27.58927

and

evaluated expected difference
1533.128 1533.128 0
1499.986 1533.128 -33.1419
1499.986 1533.128 -33.142
1499.986 1533.128 -33.142
1499.986 1533.128 -33.142
1499.986 1533.128 -33.142
1499.986 1533.128 -33.142
1499.986 1533.128 -33.142
1499.986 1533.128 -33.142
1499.986 1533.128 -33.142
1499.986 1533.128 -33.142
@visr visr added the test Relates to unit testing label Apr 23, 2024
@github-project-automation github-project-automation bot moved this to To do in Ribasim Apr 23, 2024
@SouthEndMusic
Copy link
Collaborator

This was probably solved with e84ae3a, let's merge that separately.

@SouthEndMusic SouthEndMusic added the allocation Allocation layer label Apr 23, 2024
@visr visr mentioned this issue Apr 23, 2024
Merged
@visr
Copy link
Member Author

visr commented Apr 23, 2024

That makes sense, see #1424.

SouthEndMusic added a commit that referenced this issue Apr 24, 2024
@visr @SouthEndMusic
FlowBoundary is flow direction constraining (#1424)
6c266af 
(cherry picked from commit e84ae3a)

Fixes #1423

---------

Co-authored-by: Bart de Koning <[email protected]>
@github-project-automation github-project-automation bot moved this from To do to ✅ Done in Ribasim Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
allocation Allocation layer test Relates to unit testing
Projects
Ribasim
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FlowBoundary is flow direction constraining Deltares/Ribasim
2 participants
@visr @SouthEndMusic