Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the solver integrate our flows #1431

Closed
visr opened this issue Apr 25, 2024 · 1 comment
Closed

Let the solver integrate our flows #1431

visr opened this issue Apr 25, 2024 · 1 comment
Assignees
Labels
core Issues related to the computational core in Julia

Comments

@visr
Copy link
Member

visr commented Apr 25, 2024

We compute mean or total flows in several places, and do this manually in our parameters in for instance #1300.

@SouthEndMusic suggested that perhaps it would be less code and more accurate to add those "integrated flows [m3]" as a state to our solver, such that du = flow [m3/s]. We already have two types of state, one for the Basin volume, and the PID error. We can add more.

@visr visr added core Issues related to the computational core in Julia improvement labels Apr 25, 2024
@github-project-automation github-project-automation bot moved this to To do in Ribasim Apr 25, 2024
@SouthEndMusic SouthEndMusic moved this from To do to 🏗 In progress in Ribasim Apr 29, 2024
@Jingru923 Jingru923 moved this from 🏗 In progress to 👀 In review in Ribasim May 13, 2024
@SouthEndMusic
Copy link
Collaborator

Closed in favor of #1473.

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Ribasim May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues related to the computational core in Julia
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants