Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interweave internal_sources and collect_demand allocation runs #1442

Closed
SouthEndMusic opened this issue Apr 29, 2024 · 2 comments
Closed

Interweave internal_sources and collect_demand allocation runs #1442

SouthEndMusic opened this issue Apr 29, 2024 · 2 comments
Labels
allocation Allocation layer

Comments

@SouthEndMusic
Copy link
Collaborator

SouthEndMusic commented Apr 29, 2024

Since #1429 we set the source capacities to 0 when collecting subnetwork demands, to make sure that only flow from the main network inlet(s) is used to collect subnetwork demands. However, user return flow and buffers can create internal sources for later priorities, making the subnetwork demand not fully constrained once again. We could go the route of setting the source capacities to 0 before each priority, instead of only before the whole collect_demands run as we do now. We could also invest more time into giving priorities to sources (#565), which is a more generic approach which also makes better use of local available water.

@SouthEndMusic SouthEndMusic added needs-refinement Issues that are too large and need refinement allocation Allocation layer labels Apr 29, 2024
@github-project-automation github-project-automation bot moved this to To do in Ribasim Apr 29, 2024
@SouthEndMusic SouthEndMusic removed the needs-refinement Issues that are too large and need refinement label Apr 30, 2024
@SouthEndMusic SouthEndMusic changed the title Set the source capacities to 0 before every priority when collecting demands Interweave internal_sources and collect_demand allocation runs Apr 30, 2024
@SouthEndMusic
Copy link
Collaborator Author

This was discussed by @SnippenE, but more in detail by @gijsber and me. We came to the conclusion to no longer separate the internal_sources and collect_demands runs, but to interweave them. That is: for every priority, first do an internal_sources and then a collect_demands run. That way internal sources that are created during demand collection are always used up before the next collect_demands run, and their capacity does not have to be thrown away.
But I still think the internal source capacities should be temporarily set to 0 when collecting subnetwork demands to be absolutely sure that flow can only come from the main network.

@SouthEndMusic
Copy link
Collaborator Author

Superseded by #565.

@github-project-automation github-project-automation bot moved this from To do to ✅ Done in Ribasim May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
allocation Allocation layer
Projects
Archived in project
Development

No branches or pull requests

1 participant