Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Delwaq receives correct network typology #1506

Closed
SnippenE opened this issue May 29, 2024 · 3 comments · Fixed by #1519
Closed

Ensure Delwaq receives correct network typology #1506

SnippenE opened this issue May 29, 2024 · 3 comments · Fixed by #1519
Assignees
@evetion
Labels
waterquality Issues related to Delwaq coupling/functionality

Comments

@SnippenE
Copy link

see attachment. current status is not representing the Ribasim network correct

Image
@SnippenE SnippenE added this to Ribasim May 29, 2024
@github-project-automation github-project-automation bot moved this to To do in Ribasim May 29, 2024
@SnippenE SnippenE added the waterquality Issues related to Delwaq coupling/functionality label May 29, 2024
@SnippenE SnippenE moved this from To do to What's next in Ribasim May 29, 2024
@evetion evetion moved this from What's next to Sprint backlog in Ribasim May 30, 2024
@evetion evetion moved this from Sprint backlog to 🏗 In progress in Ribasim Jun 3, 2024
@evetion evetion self-assigned this Jun 3, 2024
@evetion evetion mentioned this issue Jun 3, 2024
Merged
@evetion
Copy link
Member

evetion commented Jun 3, 2024

Fixed in #1519:
Image

@gijsber
Copy link
Contributor

gijsber commented Jun 3, 2024

Oude tijden herleven. dit doet erg aan een DM model schematisatie denken
image

@visr
Copy link
Member

visr commented Jun 3, 2024

The original Edge geometries of this model nicely follow the waterways, but in model.to_xugrid we currently drop this information and preserve only the topology. We could probably add it to the datamodel under UGrid or Deltares conventions like done for reaches.

@visr visr closed this as completed in #1519 Jun 3, 2024
visr pushed a commit that referenced this issue Jun 3, 2024
@evetion
Fix edge table in netCDF used for Delwaq coupling. (#1519)
e0c8886 
Fixes #1506
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Ribasim Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evetion evetion

Labels
waterquality Issues related to Delwaq coupling/functionality
Projects
Ribasim
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix edge table in netCDF used for Delwaq coupling. Deltares/Ribasim
4 participants
@visr @evetion @gijsber @SnippenE