Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Listen to substance and concentration for control #1610

Closed
evetion opened this issue Jul 4, 2024 · 5 comments · Fixed by #1660
Closed

Listen to substance and concentration for control #1610

evetion opened this issue Jul 4, 2024 · 5 comments · Fixed by #1660
Assignees
@SouthEndMusic
Labels
control Rule based control of physical layer

Comments

@evetion
Copy link
Member

evetion commented Jul 4, 2024 •
edited by SnippenE
Loading

Change control to allow also other conditions to listen to (besides level and flow)
@evetion evetion added this to Ribasim Jul 4, 2024
@evetion evetion converted this from a draft issue Jul 4, 2024
@evetion evetion added the v1.0 label Jul 4, 2024
@visr visr changed the title Control (steer) on substance and concentration Listen to substance and concentration for control Jul 4, 2024
@gijsber gijsber added the control Rule based control of physical layer label Jul 4, 2024
@gijsber gijsber moved this from To do to What's next in Ribasim Jul 4, 2024
@Jingru923 Jingru923 added the needs-refinement Issues that are too large and need refinement label Jul 5, 2024
@SnippenE SnippenE removed the needs-refinement Issues that are too large and need refinement label Jul 15, 2024
@SouthEndMusic SouthEndMusic self-assigned this Jul 24, 2024
@SouthEndMusic
Copy link
Collaborator

Is this specifically for Basin / ConcentrationExternal?

@SouthEndMusic SouthEndMusic moved this from What's next to 🏗 In progress in Ribasim Jul 24, 2024
@gijsber
Copy link
Contributor

gijsber commented Jul 24, 2024

Initially yes, in later stage we also want it to work on the Basin /Concentration table

@SouthEndMusic
Copy link
Collaborator

Are the tables deliberately written into the geopackage file as BasinConcentration / external and BasinConcentration / state in stead of Basin / *? Could this explain why I cannot retrieve the data in these tables with load_structvector(db, config, BasinConcentrationExternalV1) in the core?

@gijsber
Copy link
Contributor

gijsber commented Jul 24, 2024

@evetion and @visr have been think about this for a while, so I assume it was deliberate.

@visr
Copy link
Member

visr commented Jul 24, 2024

Should be Basin / *, as added in #1267.

@SouthEndMusic SouthEndMusic moved this from 🏗 In progress to 👀 In review in Ribasim Jul 25, 2024
@SouthEndMusic SouthEndMusic mentioned this issue Jul 25, 2024
Merged
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Ribasim Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SouthEndMusic SouthEndMusic

Labels
control Rule based control of physical layer
Projects
Ribasim
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Listen to concentration Deltares/Ribasim
6 participants
@visr @evetion @gijsber @Jingru923 @SouthEndMusic @SnippenE