DiscreteControl doesn't seem to pass correct control_state to Outlets

[DanielTollenaar]

What dit we do
We build a model with DiscreteControl node (node_id 1000002):

• Listening to a FlowBoundary at Monsin (node_id 7011)
• Controlling multiple Outlets, regulating flows trough the Meuse and Belgium/Dutch canal systems

For the remainder we focus on the diversion at Borgharen (node_id = 7764), Julianakanaal (node_id = 7925) and verbindingskanaal (node_id = 7759). We use a steady-state model with bc 450 m3/s at Monsin available via transfer: https://we.tl/t-Ybsly5S9hX

Expected result
At 450 m3/s we would be at control_state Monsin_186 (see DiscreteControl / condition):

That would give us an min_crest_level at node_id's 7759, 7764 and 7925 of 44.21 m NAP (see Outlet / static). Thereby we would expect a water-level at the upstream Basin (node_id 7706) of +/- 44.2 m NAP:

Actual result
We see a water-level of > 48.09m NAP at Basin 7706, which is much higher than expected. This level corresponds at the highest control_states in our table, which should apply at discharges > 7100 m3/s at Monsin:

Additional information
Our analysis stops here, we suspect the controller some-how got lost. If we could see the actual crest_level of Outlet during simulation, and control_state at DiscreteControl we could verify further. Would it be an idea to user-define storage of results for different node-types in a results-section of the toml-file (following SOBEK functionality)?

[visr]

Thanks for the report. Good to look into this

If we could see the actual crest_level of Outlet during simulation, and control_state at DiscreteControl we could verify further.

Have you looked at control.arrow? https://deltares.github.io/Ribasim/reference/usage.html#discretecontrol---control.arrow

[gijsber]

Hi @visr , is this one to check before pushing out the release ?

[visr]

I don't really see an error, but perhaps I am misunderstanding. In any case this should be done with ContinueousControl once #1602 is released.

What I don't follow is you seem to expect that the upstream Basin level is equal to the set min_crest_level. Instead what you can expect is that as long as the level is above the min_crest_level (which it is), that the flow rate over the Outlet is equal to the set flow rate. Comparing the control.arrow, data tables and flow.arrow, I can see this is the case, modulo small differences due to reduction factors.

@DanielTollenaar feel free to reopen if I miss something.