Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convergence bottlenecks not always shown #1759

Closed
visr opened this issue Aug 26, 2024 · 1 comment · Fixed by #1770
Closed

Convergence bottlenecks not always shown #1759

visr opened this issue Aug 26, 2024 · 1 comment · Fixed by #1770
Labels
core Issues related to the computational core in Julia

Comments

@visr
Copy link
Member

visr commented Aug 26, 2024

This should show the bottlenecks. If it cannot show them, due to a particular algorithm or such, we should not log the warning line at all. I thought the code already took this into account. This was added in #1440 and modified in #1636, perhaps I broke it there?

image
@github-project-automation github-project-automation bot moved this to To do in Ribasim Aug 26, 2024
@visr visr added bug core Issues related to the computational core in Julia labels Aug 26, 2024
@DanielTollenaar
Copy link
Contributor

Model is here: https://we.tl/t-q8RuGG5XfQ

@SouthEndMusic SouthEndMusic mentioned this issue Aug 27, 2024
Merged
evetion pushed a commit that referenced this issue Aug 27, 2024
@SouthEndMusic
Give no bottleneck warning if no bottleneck basins were found (#1770)
4cf93b5 
Fixes #1759
@github-project-automation github-project-automation bot moved this from To do to ✅ Done in Ribasim Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Issues related to the computational core in Julia
Projects
Ribasim
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Give no bottleneck warning if no bottleneck basins were found Deltares/Ribasim
2 participants
@visr @DanielTollenaar