Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give comprehensive error messages for idx<0 in core #1824

Closed
Jingru923 opened this issue Sep 19, 2024 · 0 comments · Fixed by #1826
Closed

Give comprehensive error messages for idx<0 in core #1824

Jingru923 opened this issue Sep 19, 2024 · 0 comments · Fixed by #1826
Assignees
@Jingru923
Labels
core Issues related to the computational core in Julia validation Related to model validation

Comments

@Jingru923
Copy link
Contributor

Jingru923 commented Sep 19, 2024 •
edited
Loading

What
In the initialization of NodeID in file parameter.jl, there are assertion handles that make sure the index of NodeID is bigger than 0. However, when a user didn't pass correct input data or passes nothing, the error message doesn't explain the situation.

How
Add error messages for the assert in function NodeID
@github-project-automation github-project-automation bot moved this to To do in Ribasim Sep 19, 2024
@Jingru923 Jingru923 added core Issues related to the computational core in Julia validation Related to model validation labels Sep 19, 2024
@Jingru923 Jingru923 self-assigned this Sep 19, 2024
@Jingru923 Jingru923 moved this from To do to 🏗 In progress in Ribasim Sep 19, 2024
@Jingru923 Jingru923 linked a pull request Sep 19, 2024 that will close this issue
Error messages for invalid NodeID #1826
Merged
@Jingru923 Jingru923 mentioned this issue Sep 19, 2024
Merged
@visr visr closed this as completed in 87f535f Sep 19, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Ribasim Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jingru923 Jingru923

Labels
core Issues related to the computational core in Julia validation Related to model validation
Projects
Ribasim
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Error messages for invalid NodeID Deltares/Ribasim
1 participant
@Jingru923