Avoiding negative flows where they should not be #1900
Labels
core
Issues related to the computational core in Julia
performance
Relates to runtime performance or convergence
(Somewhat of a duplicate of #1838)
After the refactor #1819 we found that flows that should be non-negative are sometimes negative for a brief period of time (or maybe it already happened before, but we just now discovered it by looking at tracers?). I discussed this on Slack:
Several solutions were proposed above depending on where the problem originates:
stage_limiter
to the nonlinear solver (@visr had some comments about this, it would be nice if you add them below)If the above options don't work we could also implement a callback for enforcing non-negative flows. Some notes about this:
u_modified!
weren't very promising:The text was updated successfully, but these errors were encountered: