Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Place and improve allocation test model WiBo in testbank #1936

Closed
gijsber opened this issue Nov 14, 2024 · 0 comments · Fixed by #2056
Closed

Place and improve allocation test model WiBo in testbank #1936

gijsber opened this issue Nov 14, 2024 · 0 comments · Fixed by #2056
Labels
allocation Allocation layer CI/CD Continuous Integration/Continuous deployment

Comments

@gijsber
Copy link
Contributor

gijsber commented Nov 14, 2024 •
edited by SnippenE
Loading

Create model Josje (Wibo) and build towards testmodel in testbank. Testmodels in this link: https://publicwiki.deltares.nl/download/attachments/232326570/Bommelerwaard_modellen_gebruikt_voor_berekeningen.zip?version=1&modificationDate=1720040275749&api=v2
@gijsber gijsber added allocation Allocation layer CI/CD Continuous Integration/Continuous deployment labels Nov 14, 2024
@gijsber gijsber added this to Ribasim Nov 14, 2024
@github-project-automation github-project-automation bot moved this to To do in Ribasim Nov 14, 2024
@gijsber gijsber moved this from To do to Sprint backlog in Ribasim Nov 14, 2024
@gijsber gijsber changed the title Allocatie test model WiBo in testbank zetten en doorontwikkelen Place and improve allocation test model WiBo in testbank Nov 14, 2024
@SouthEndMusic SouthEndMusic mentioned this issue Feb 12, 2025
Merged
@SnippenE SnippenE moved this from Sprint backlog to 👀 In review in Ribasim Feb 13, 2025
visr added a commit that referenced this issue Feb 21, 2025
@SouthEndMusic @visr
Bommelerwaard test model (#2056)
5b2fd47 
Fixes #1936.

Notes:
- I had to remove the truth states with "U" and "D" as we no longer
support these (also removed this from the docs)
- We no longer support ManningResistance connecting to LevelBoundary so
I converted one ManningResistance to LinearResistance (node 29)
- Also updated the Link table in the docs (`usage.md`) as this still
mentioned node types
- I had to refactor handling sources for allocation a bit because this
model hits an edge (link) case I hadn't considered yet

---------

Co-authored-by: Martijn Visser <[email protected]>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Ribasim Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
allocation Allocation layer CI/CD Continuous Integration/Continuous deployment
Projects
Ribasim
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bommelerwaard test model Deltares/Ribasim
1 participant
@gijsber