You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Before Ribasim becomes more widely used, it is good to consider feedback from new users. One such feedback is that some names we use may cause some confusion.
Edge
Why: The name Edge is commonly used in graph theory, but is not so common in hydrological modeling.
Alternatives: Link.
Basin
Why: Basin's don't necessarily need to align with basins or watersheds. Basins always need some explanation of them representing (a part of a) water body with a certain storage and level.
Alternatives:
Waterbody: We should try to think ahead if this would still make sense if we will add other node types representing water bodies, like Add Confluence node #1609 or reservoirs.
LevelPool was mentioned by Joe Hughes. I see this used in Surface-Water Routing (SWR) docs, and see references like in HEC-RAS docs.
Reach, used in SWR and other software, makes it clear that it is a part of a river or stream.
LevelStorage
...
Implementation
These renames can be very breaking for users, which is a reason not to wait too long. Though doing them right now isn't great for https://github.com/Deltares/Ribasim-NL progress. Ribasim Python migration can do the renames, and potentially offer the old names as API aliases temporarily. The core could have a period in which it looks for the old table names if the new ones don't exist.
Note: Implementation can also have an impact on the BMI and thus the coupling with MFMS
The text was updated successfully, but these errors were encountered:
Before Ribasim becomes more widely used, it is good to consider feedback from new users. One such feedback is that some names we use may cause some confusion.
Edge
Why: The name Edge is commonly used in graph theory, but is not so common in hydrological modeling.
Alternatives: Link.
Basin
Why: Basin's don't necessarily need to align with basins or watersheds. Basins always need some explanation of them representing (a part of a) water body with a certain storage and level.
Alternatives:
Confluence
node #1609 or reservoirs.Implementation
These renames can be very breaking for users, which is a reason not to wait too long. Though doing them right now isn't great for https://github.com/Deltares/Ribasim-NL progress. Ribasim Python migration can do the renames, and potentially offer the old names as API aliases temporarily. The core could have a period in which it looks for the old table names if the new ones don't exist.
Note: Implementation can also have an impact on the BMI and thus the coupling with MFMS
The text was updated successfully, but these errors were encountered: