Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ManningResistance cannot be connected to a LevelBoundary #334

Closed
Huite opened this issue Jun 19, 2023 · 2 comments · Fixed by #336
Closed

ManningResistance cannot be connected to a LevelBoundary #334

Huite opened this issue Jun 19, 2023 · 2 comments · Fixed by #336
Assignees
@visr

Comments

@Huite
Copy link
Contributor

Huite commented Jun 19, 2023 •
edited
Loading

Connecting a ManningResistance to a LevelBoundary is theoretically sound: there's a level to use. I think the validation doesn't allow it:

ERROR: AssertionError: node_id 102 not a Basin

Of course, the logic probably doesn't exist either...
But we should at least consider adding it.
@github-project-automation github-project-automation bot moved this to To do in Ribasim Jun 19, 2023
@visr
Copy link
Member

visr commented Jun 19, 2023

It's because the bottom is missing. I made this PR last week: #330. Though if you know how to actually solve it that may be better.

@Huite
Copy link
Contributor Author

Huite commented Jun 19, 2023

Could we just use the bottom of the associated node instead? I guess we have to special case it in the formulate function?

@visr visr mentioned this issue Jun 19, 2023
Closed
@visr visr self-assigned this Jun 19, 2023
@visr visr mentioned this issue Jun 19, 2023
Merged
@visr visr closed this as completed in #336 Jun 19, 2023
visr added a commit that referenced this issue Jun 19, 2023
@visr
support ManningResistance and LevelBoundary (#336)
32aa36c 
Fixes #334 

By taking the other sides' bottom as suggested in
#334 (comment)

Closes #330
@github-project-automation github-project-automation bot moved this from To do to ✅ Done in Ribasim Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@visr visr

Labels
None yet
Projects
Ribasim
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support ManningResistance and LevelBoundary Deltares/Ribasim
2 participants
@visr @Huite