Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize reduction factor #591

Closed
visr opened this issue Sep 12, 2023 · 3 comments
Closed

standardize reduction factor #591

visr opened this issue Sep 12, 2023 · 3 comments

Comments

@visr
Copy link
Member

visr commented Sep 12, 2023

          I made this plot of the smooth reduction factor:

reduction_factor_plot

how can I add it to equations.qmd? It has been added now.

Originally posted by @SouthEndMusic in #549 (comment)

Bart made a nicer reduction factor. We should probably use this one for all the reduction_factors, which is now generally a linear reduction. Most are hardcoded to work until 10m3, for Manning it is 10cm waterdepth. Let's see if we can share this and/or make it configurable.

@evetion
Copy link
Member

evetion commented Sep 12, 2023

Probably any sigmoid function will work?

@visr
Copy link
Member Author

visr commented Sep 12, 2023

Probably. Sigmoid looks more expensive than this, and only approaches the right value, so it is not smooth at the threshold.

@visr
Copy link
Member Author

visr commented Sep 12, 2023

Sorry I should've checked #549 better first, it already moves all reduction factors over.

@visr visr closed this as completed Sep 12, 2023
@github-project-automation github-project-automation bot moved this from To do to ✅ Done in Ribasim Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants