Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stepping over events #595

Closed
visr opened this issue Sep 13, 2023 · 0 comments · Fixed by #1418
Closed

Stepping over events #595

visr opened this issue Sep 13, 2023 · 0 comments · Fixed by #1418
Assignees

Comments

@visr
Copy link
Member

visr commented Sep 13, 2023

I found something peculiar when working on the test model for the Outlet:

outlet_model

outlet_constraints

In the current state it behaves as expected, that is: there is no outlet flow until the level boundary reaches the minimum crest level, and the basin level converges to the level boundary level. However, when the basin starts completely empty instead of with a tiny amount of water, it doesn't fill:

outlet_constraints_noflow

I haven't been able to figure out why this happens.

Originally posted by @SouthEndMusic in #549 (comment)

As can be seen from the dots on the blue line, the solver steps over the on-ramp entirely.

I modified the solver settings of the outlet test model, to use fixed time steps. This avoids the issue described above. It isn't clear to me why the initial state of 0 vs 0.001 m3 matters in this regard.

[solver]
adaptive=false
dt = 86400.0

We should understand this issue better, and see if we can do something about it. Right now we use tstops to tell the solver to stop when a flow boundary changes, but probably we need to include more moments here.

@github-project-automation github-project-automation bot moved this to To do in Ribasim Sep 13, 2023
@visr visr added the bug label Sep 18, 2023
@SnippenE SnippenE moved this from To do to What's next in Ribasim Feb 22, 2024
@elinenauta elinenauta moved this from What's next to 🏗 In progress in Ribasim Apr 23, 2024
@visr visr changed the title stepping over events Stepping over events Apr 23, 2024
@SouthEndMusic SouthEndMusic self-assigned this Apr 23, 2024
visr pushed a commit that referenced this issue Apr 23, 2024
Fixes #595



This problem shown in the issue seems to be resolved, I can't reproduce
it. When I went back to the default solver and initial level of $0$, I
still get the same graph:

![fine_graph](https://github.com/Deltares/Ribasim/assets/74617371/cfdc91fd-9ab4-4126-995a-0b9712be406b)
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Ribasim Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants