Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for SubgridLevel interpolation #681

Closed
Huite opened this issue Oct 19, 2023 · 1 comment
Closed

Add validation for SubgridLevel interpolation #681

Huite opened this issue Oct 19, 2023 · 1 comment
Assignees
@Huite
Labels
coupling Coupling to other models

Comments

@Huite
Copy link
Contributor

Huite commented Oct 19, 2023

The use of IterTools.groupby requires that everything is sorted properly:

  • by name first
  • by element_id second
  • by node_id third (?)
  • by basin_level last

The element level should also be monotonic ascending.
@Huite Huite added the coupling Coupling to other models label Oct 19, 2023
@Huite Huite self-assigned this Oct 19, 2023
@github-project-automation github-project-automation bot moved this to To do in Ribasim Oct 19, 2023
@Huite Huite mentioned this issue Oct 19, 2023
Closed
@SnippenE SnippenE moved this from To do to Sprint backlog in Ribasim Oct 26, 2023
@Huite
Copy link
Contributor Author

Huite commented Nov 27, 2023

Fixed by #674

@Huite Huite closed this as completed Nov 27, 2023
@github-project-automation github-project-automation bot moved this from Sprint backlog to ✅ Done in Ribasim Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Huite Huite

Labels
coupling Coupling to other models
Projects
Ribasim
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Huite