Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor edits of comments #1908

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Minor edits of comments #1908

merged 1 commit into from
Oct 18, 2024

Conversation

visr
Copy link
Member

@visr visr commented Oct 17, 2024

No description provided.

@visr visr requested a review from evetion October 17, 2024 11:28
Copy link
Member

@evetion evetion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should write Martijn's style guide on how fill! is bad.

@evetion evetion merged commit 82a4a74 into main Oct 18, 2024
27 checks passed
@evetion evetion deleted the post-review branch October 18, 2024 08:26
@visr
Copy link
Member Author

visr commented Oct 18, 2024

Nothing bad about fill, we just use the other way everywhere else in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants