Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce experimental config section and use it for concentrations. #1909

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

evetion
Copy link
Member

@evetion evetion commented Oct 17, 2024

I almost went for StyledStrings, but the underline (here **) seems enough.

┌ Info: Starting a Ribasim simulation.
│   toml_path = "/Users/evetion/Downloads/hws_2024_7_x_delwaq/hws_24h.toml"
│   cli.ribasim_version = "2024.11.0"
│   starttime = 2023-01-20T00:00:00
└   endtime = 2023-07-01T00:00:00
┌ Warning: The following *experimental* features are enabled: concentration
└ @ Ribasim /Users/evetion/code/Ribasim/core/src/main.jl:44

@evetion evetion requested a review from visr October 17, 2024 19:33
Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

::: {.callout-caution}
This is an unsupported experimental feature and is disabled by default.
We advise to use the [Delwaq coupling](@sec-waterquality) for tracer calculations.
If you're interested in using this experimental feature, please [contact us](../contact.qmd).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you're interested in using this experimental feature, please [contact us](../contact.qmd).
If you're interested in using this experimental feature, please [contact us](/contact.qmd).

::: {.callout-important}
Experimental features are completely unsupported. They can break at any time
and results will be wrong. **Do not use them in production**. If you're interested
in using an experimental feature, please [contact us](../contact.qmd).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
in using an experimental feature, please [contact us](../contact.qmd).
in using an experimental feature, please [contact us](/contact.qmd).

@visr visr merged commit 66491af into main Oct 21, 2024
5 of 11 checks passed
@visr visr deleted the feat/experimental branch October 21, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants