Sort DataFrames inplace. #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visr
approved these changes
Sep 14, 2023
|
Can confirm that this no longer triggers validation on write. |
So the tables are subheadings of the node types.
visr
force-pushed
the
fix/sort-inplace
branch
from
e5bf8ab to
dc0c288
Compare
|
Turns out the Ubuntu CI failure was due to a missing custom sort method. Brought them all up to date with our docs in dc0c288. @evetion already mentioned that the sort algorithm on Linux could be slightly different, and we just luckily ended up with a sorted GeoPackage on Windows. On top of that, we sort data when reading it into the core as well, so not sorting in Python should not lead to test failures. But those were similarly outdated, fixed in fe64269. |
6 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the performance of saving a Ribasim model in Python.
When we sorted, we assigned the returned dataframe to our model, triggering validation.