Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send error if glacier is true and state/parameters are missing #322

Open
hboisgon opened this issue Dec 22, 2023 · 3 comments
Open

Send error if glacier is true and state/parameters are missing #322

hboisgon opened this issue Dec 22, 2023 · 3 comments
Labels
user-experience Improvements to the settings file, logging, error handling, etc.

Comments

@hboisgon
Copy link
Contributor

Feature type

Changing existing functionality

Improvement Description

When setting glacier = true in TOML, wflow does not send an error if the state (and parameters) are missing, the way it does for lakes or reservoirs. So if you are a bit forgetful, while you think you model glaciers in fact you do not (if glacierfrac is not found then it defaults to 0 so no glaciers).

Implementation Description

Maybe like for lake and reservoirs, make the glacierfrac and glacierstore parameter and states mandatory (optional=False) if glaciers is True?

Additional Context

No response

@JoostBuitink
Copy link
Contributor

I think this is the same issue as issue #293, right? I also think think this might be a good issue to tackle for a v1.0

@hboisgon
Copy link
Contributor Author

Partly, I would also like the error if using cold states in that case (so make glacierfrac mandatory?)

@JoostBuitink
Copy link
Contributor

Ah I see, yes that makes sense!

@JoostBuitink JoostBuitink added the user-experience Improvements to the settings file, logging, error handling, etc. label Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user-experience Improvements to the settings file, logging, error handling, etc.
Projects
None yet
Development

No branches or pull requests

2 participants