Add local inertial routing scheme to sbm_gwf concept.
#371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`graph_riv` is used for initialization land component local inertial model
Used for river local inertial routing, the river depth was set at zero in the code. Now a user can provide this boundary condition through the TOML file or NetCDF file with model parameters. Also, the `riverlength_bc` can be set through the NetCDF file with model parameters.
- Read boundary conditions for local inertial routing from NetCDF file. - Change reading boundary conditions from TOML and NetCDF (different combinations are possible).
- make use of one `set_states` function for both model types. - add test warm start `sbm_gwf` model type.
JoostBuitink
requested changes
Mar 19, 2024
Also throw a warning about boundary condition `riverlength_bc`.
Extraction of sub-domains for kinematic wave (use of threads) and use of `network.land.slope` for lateral snow transport.
JoostBuitink
approved these changes
Mar 26, 2024
|
Ah maybe one small comment, maybe good to add that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #344
Explanation
See issue #344.
Checklist
master