Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change from using to import, or specify which functions we are importing from external libraries #375

Open
JoostBuitink opened this issue Mar 21, 2024 · 2 comments
Open

Change from using to import, or specify which functions we are importing from external libraries #375

JoostBuitink opened this issue Mar 21, 2024 · 2 comments
Labels
v1.0 Activities related to v1.0

Comments

@JoostBuitink
Copy link
Contributor

Feature type

Changing existing functionality

Improvement Description

Right now, we are using using NCDatasts for example in our code. For some functions, it is not fully clear where the functions are imported from (either Wflow.jl functions, or some other imported functions).

Implementation Description

No response

Additional Context

No response
@JoostBuitink JoostBuitink added the v1.0 Activities related to v1.0 label Mar 21, 2024
@JoostBuitink JoostBuitink changed the title Specify which functions Change from using to import, or specify which functions we are importing from external libraries Mar 21, 2024
@visr
Copy link
Member

visr commented Mar 21, 2024

Luckily https://github.com/ericphanson/ExplicitImports.jl recently came out. I used it for Ribasim as well: Deltares/Ribasim#1198

@JoostBuitink
Copy link
Contributor Author

Awesome, looks very useful! Thanks for sharing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v1.0 Activities related to v1.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@visr @JoostBuitink