Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SBM variables vwc_root and vwc_percroot can have NaN values #416

Closed
2 tasks done
verseve opened this issue May 14, 2024 · 1 comment
Closed
2 tasks done

SBM variables vwc_root and vwc_percroot can have NaN values #416

verseve opened this issue May 14, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@verseve
Copy link
Contributor

verseve commented May 14, 2024

Wflow version checks

  • I have checked that this issue has not already been reported.

  • I have checked that this bug exists on the latest version of Wflow.

Reproducible Example

A wflow_sbm model with zero rootingdepth values.

Current behaviour

When the rootingdepth is zero, vwc_root and vwc_percroot result in NaN.

Desired behaviour

When the rootingdepth is zero, vwc_root and vwc_percroot should be set at zero.

Additional Context

No response

@verseve verseve added the bug Something isn't working label May 14, 2024
@verseve verseve self-assigned this May 14, 2024
@verseve
Copy link
Contributor Author

verseve commented May 14, 2024

Actually, after a bit more thinking these NaN values are fine. The Wflow ZMQ server (JSON) cannot deal with NaNs, see issue #392, and this should be fixed there.

@verseve verseve closed this as not planned Won't fix, can't repro, duplicate, stale May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant