Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick boundary fix #430

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Quick boundary fix #430

merged 3 commits into from
Jun 11, 2024

Conversation

dalmijn
Copy link
Contributor

@dalmijn dalmijn commented Jun 11, 2024

Issue addressed

Fixes #429

Explanation

See issue #429

Checklist

  • Branch is up to date with master
  • Tests & pre-commit hooks pass
  • Updated documentation if needed
  • Updated changelog.md if needed

@dalmijn dalmijn requested a review from verseve June 11, 2024 06:54
Copy link
Contributor

@verseve verseve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this issue quickly, @dalmijn !
To improve readability a bit I assigned lateral.subsurface.flow.constanthead to constanthead and lateral.subsurface.flow.aquifer to aquifer. Also updated the changelog.

@dalmijn
Copy link
Contributor Author

dalmijn commented Jun 11, 2024

@verseve, thanks for adding it to the changelog!
Improvement of readability looks very logical/ good.
Shall I then merge it?

@verseve
Copy link
Contributor

verseve commented Jun 11, 2024

@verseve, thanks for adding it to the changelog! Improvement of readability looks very logical/ good. Shall I then merge it?

Yes, the honor is yours :-)

@dalmijn dalmijn merged commit 4becf7b into master Jun 11, 2024
10 checks passed
@visr visr deleted the gw_chb branch June 11, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model type sbm_gwf: do not reset heads for constanthead boundary
3 participants