Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialization of LateralSSF variables ssf and ssfmax with ksat_profile exponential_constant #473

Closed
2 tasks done
verseve opened this issue Oct 2, 2024 · 0 comments · Fixed by #487
Closed
2 tasks done

Initialization of LateralSSF variables ssf and ssfmax with ksat_profile exponential_constant #473

verseve opened this issue Oct 2, 2024 · 0 comments · Fixed by #487
Assignees
@verseve
Labels
bug Something isn't working

Comments

@verseve
Copy link
Contributor

verseve commented Oct 2, 2024

Wflow version checks

  • I have checked that this issue has not already been reported.

  • I have checked that this bug exists on the latest version of Wflow.

Reproducible Example

Initialize a wflow_sbm model with ksat_profile = exponential_constant

Current behaviour

The variables ssfmax and ssf are overestimated. In the computation the parameter khfrac is used, this parameter is already used for the computation of kh_0, so khfrac is applied twice.

Desired behaviour

Remove parameter khfrac from the computation.

Additional Context

No response
@verseve verseve added the bug Something isn't working label Oct 2, 2024
@verseve verseve self-assigned this Oct 2, 2024
@verseve verseve mentioned this issue Oct 2, 2024
Closed
5 tasks
@verseve verseve linked a pull request Oct 18, 2024 that will close this issue
Refactor SBM concept #487
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@verseve verseve

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@verseve