Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove git-tree-sha1 from metadata #480

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Remove git-tree-sha1 from metadata #480

merged 3 commits into from
Oct 10, 2024

Conversation

verseve
Copy link
Contributor

@verseve verseve commented Oct 9, 2024

It is not part of the Wflow entry in the Manifest.toml file and as a result the build fails.

Issue addressed

Fixes #479

It is not part of the Wflow entry in the Manifest.toml file and as a result the build fails.
@verseve verseve requested review from visr and JoostBuitink October 9, 2024 06:31
@visr
Copy link
Member

visr commented Oct 10, 2024

If we don't have the git-tree-sha1 or the commit, we only have the branch and the version number, which is not enough to identify the source of the build. This started failing since the build script moved into this repository, hence it is not in the metadata. It's no problem to remove the git-tree-sha1 but then I'd at least add the commit.

For Ribasim we add this to the README.md in the root of our build:

release = "2024.10.0-128-ge09eeb5"
commit = "https://github.com/Deltares/Ribasim/tree/e09eeb5b9a"
branch = "https://github.com/Deltares/Ribasim/tree/main"
julia_version = "1.10.5"
core_version = "2024.11.0"

With additionally in share/julia/Build.toml the TeamCity build number, in case it was built on TeamCity:

BUILD_NUMBER = "1342"
BUILD_VCS_NUMBER = "e09eeb5b9ad46b9715a3aa5ba47fc69b03b48789"

You can take what you want from https://github.com/Deltares/Ribasim/blob/4048a50367dbc4f28975b28f6c6da76cb77e3ea5/build/build.jl#L92

@verseve
Copy link
Contributor Author

verseve commented Oct 10, 2024

If we don't have the git-tree-sha1 or the commit, we only have the branch and the version number, which is not enough to identify the source of the build. This started failing since the build script moved into this repository, hence it is not in the metadata. It's no problem to remove the git-tree-sha1 but then I'd at least add the commit.

Thanks for the info. I think this started failing with the latest update of the Manifest.toml file: 59f5ef6#diff-4d5f121308e3da7be8f85c55dba1429a0a14f54b42c9d40eedf2d6effdcf2446L655.

Adding the commit (and aligning with Ribasim) sounds good!

Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Assuming you tested locally.

@verseve verseve merged commit 16b6b3a into master Oct 10, 2024
10 checks passed
@verseve verseve deleted the build_metadata branch October 21, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build wflow_cli fails
3 participants