Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenDA coupling #93

Closed
visr opened this issue Jan 13, 2021 · 4 comments · Fixed by #356
Closed

OpenDA coupling #93

visr opened this issue Jan 13, 2021 · 4 comments · Fixed by #356
Assignees
@verseve
Labels
coupling For coupling Wflow to other models/software v1.0 Activities related to v1.0
Milestone
Q4

Comments

@visr
Copy link
Member

visr commented Jan 13, 2021 •
edited
Loading

This will likely need BMI 2.0 support in OpenDA first.
We will probably do this using the black box model approach, using the wflow_cli.
@visr visr changed the title OpenDA coupling (Thrift) OpenDA coupling Jun 3, 2021
@verseve verseve self-assigned this Sep 13, 2022
@verseve
Copy link
Contributor

verseve commented Oct 12, 2022

Started with OpenDA memory coupling approach with Thrift.jl (black box model approach is too slow). It seems the handling of user-defined exceptions is not working properly, with Thrift-0.8.4 an error is thrown immediately, and with Thrift-0.7.1 an error is thrown when the user-defined exception occurs, see also the following issue tanmaykm/Thrift.jl#76.

@JoostBuitink JoostBuitink moved this to Todo in Wflow Oct 31, 2022
@JoostBuitink JoostBuitink added enhancement coupling For coupling Wflow to other models/software labels Oct 31, 2022
@JoostBuitink JoostBuitink moved this from 🔲 Todo to 🏗 In progress in Wflow Oct 31, 2022
@verseve
Copy link
Contributor

verseve commented Nov 24, 2022

After discussion (also with OpenDA developers) we decided to use ZeroMQ (https://zeromq.org/) instead of Thrift to run Wflow (BMI) as a server for the coupling approach.

@visr
Copy link
Member Author

visr commented Jan 25, 2023

Work in progress in the zmq_server branch: https://github.com/Deltares/Wflow.jl/tree/zmq_server
What is the status of this branch?

@verseve
Copy link
Contributor

verseve commented Jan 26, 2023

Work in progress in the zmq_server branch: https://github.com/Deltares/Wflow.jl/tree/zmq_server What is the status of this branch?

Changes on the OpenDA side are in progress. When done, the work in the zmq_server branch can be finished.

@alimeshgi alimeshgi added this to the Q4 milestone Oct 10, 2023
@JoostBuitink JoostBuitink added the v1.0 Activities related to v1.0 label Feb 8, 2024
@verseve verseve mentioned this issue Feb 12, 2024
Merged
5 tasks
@verseve verseve linked a pull request Feb 12, 2024 that will close this issue
Wflow ZMQ Server #356
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@verseve verseve

Labels
coupling For coupling Wflow to other models/software v1.0 Activities related to v1.0
Projects
No open projects
Wflow
Status: 🏗 In progress
Milestone
Q4
Development

Successfully merging a pull request may close this issue.

Wflow ZMQ Server Deltares/Wflow.jl
4 participants
@visr @verseve @JoostBuitink @alimeshgi