From 042f86b508637c0b4ef0fef5505cb8e448862fd8 Mon Sep 17 00:00:00 2001 From: Willem van Verseveld Date: Thu, 11 Jan 2024 08:05:07 +0100 Subject: [PATCH 1/4] Use `kvfrac` for computation `actleakage` Include multiplication factor `kvfrac` in the computation of vertical saturated hydraulic conductivity at the bottom of the soil, so it is consistent with unsaturated vertical flow computation. --- src/sbm.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sbm.jl b/src/sbm.jl index a85254bf7..67d2650ea 100644 --- a/src/sbm.jl +++ b/src/sbm.jl @@ -925,7 +925,7 @@ function update_until_recharge(sbm::SBM, config) actcapflux = actcapflux + toadd end end - deepksat = sbm.kv₀[i] * exp(-sbm.f[i] * sbm.soilthickness[i]) + deepksat = sbm.kvfrac[i][end] * sbm.kv₀[i] * exp(-sbm.f[i] * sbm.soilthickness[i]) deeptransfer = min(satwaterdepth, deepksat) actleakage = max(0.0, min(sbm.maxleakage[i], deeptransfer)) From ca125988d5996b2debf7763e3f54358697590c6f Mon Sep 17 00:00:00 2001 From: Willem van Verseveld Date: Thu, 11 Jan 2024 08:25:51 +0100 Subject: [PATCH 2/4] Update changelog --- docs/src/changelog.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/src/changelog.md b/docs/src/changelog.md index 5b4ccfaeb..02fdeef29 100644 --- a/docs/src/changelog.md +++ b/docs/src/changelog.md @@ -16,6 +16,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 specification that arrays are always flattened (this was not the case for variables stored as 2-dimensional arrays or as vector of SVectors). - Bump compat for NCDatasets to 0.13. +- Use `kvfrac` for the computation of vertical saturated hydraulic conductivity at the + bottom of the soil layer, since `kvfrac` is also used for the computation of vertical + unsaturated flow. ### Changed - For cyclic parameters different cyclic time inputs are supported (only one common cyclic From 9f5af8eacdfff371a4ce468b6a573ce1b33ba473 Mon Sep 17 00:00:00 2001 From: Willem van Verseveld Date: Thu, 11 Jan 2024 08:29:20 +0100 Subject: [PATCH 3/4] Fix unit docs --- docs/src/model_docs/params_lateral.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/src/model_docs/params_lateral.md b/docs/src/model_docs/params_lateral.md index 56cca1277..50326452e 100644 --- a/docs/src/model_docs/params_lateral.md +++ b/docs/src/model_docs/params_lateral.md @@ -191,7 +191,7 @@ scales (hillslope) in reality, not represented by the model resolution. | `dw` | drain width | m | - | | `zi` | pseudo-water table depth (top of the saturated zone) | m | - | | `exfiltwater` | exfiltration (groundwater above surface level, saturated excess conditions) | m Δt⁻¹ | - | -| `recharge` | net recharge to saturated store | m Δt⁻¹ | - | +| `recharge` | net recharge to saturated store | m``^2`` Δt⁻¹ | - | | `ssf` | subsurface flow | m``^3`` d``{-1}`` | - | | `ssfin` | inflow from upstream cells | m``^3`` d``{-1}`` | - | | `ssfmax` | maximum subsurface flow | m``^2`` d``{-1}`` | - | From 2d47facfb4e04bbafc9faf2e2946824fabb19a83 Mon Sep 17 00:00:00 2001 From: Willem van Verseveld Date: Thu, 11 Jan 2024 13:38:18 +0100 Subject: [PATCH 4/4] Fix unit also in code --- src/flow.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/flow.jl b/src/flow.jl index 4aaa05e1c..af77daa89 100644 --- a/src/flow.jl +++ b/src/flow.jl @@ -398,7 +398,7 @@ end dw::Vector{T} | "m" # Flow width [m] zi::Vector{T} | "m" # Pseudo-water table depth [m] (top of the saturated zone) exfiltwater::Vector{T} | "m Δt-1" # Exfiltration [m Δt⁻¹] (groundwater above surface level, saturated excess conditions) - recharge::Vector{T} | "m Δt-1" # Net recharge to saturated store [m Δt⁻¹] + recharge::Vector{T} | "m2 Δt-1" # Net recharge to saturated store [m² Δt⁻¹] ssf::Vector{T} | "m3 d-1" # Subsurface flow [m³ d⁻¹] ssfin::Vector{T} | "m3 d-1" # Inflow from upstream cells [m³ d⁻¹] ssfmax::Vector{T} | "m2 d-1" # Maximum subsurface flow [m² d⁻¹]