diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 88e124558..ed867ce49 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -9,7 +9,7 @@ Explain how you addressed the bug/feature request, what choices you made and why - [ ] Branch is up to date with `master` - [ ] Tests & pre-commit hooks pass - [ ] Updated documentation if needed -- [ ] Updated changelog.md if needed +- [ ] Updated changelog.qmd if needed ## Additional Notes (optional) Add any additional notes or information that may be helpful. \ No newline at end of file diff --git a/Dockerfile b/Dockerfile index 97e00ae56..189f2f21e 100644 --- a/Dockerfile +++ b/Dockerfile @@ -6,7 +6,9 @@ RUN apt-get update && apt-get install -y \ && rm -rf /var/lib/apt/lists/* ADD . /app WORKDIR /app/build/create_binaries/ -RUN julia --project -e "using Pkg; Pkg.instantiate()" -RUN julia --project create_app.jl +RUN julia --project -e "using Pkg; Pkg.instantiate();" && \ + julia --project download_test_data.jl && \ + julia --project create_app.jl && \ + rm -rf /app/test/data/* ENTRYPOINT [ "/app/build/create_binaries/wflow_bundle/bin/wflow_cli" ] diff --git a/docs/changelog.qmd b/docs/changelog.qmd index 65c49f596..c5ad6760f 100644 --- a/docs/changelog.qmd +++ b/docs/changelog.qmd @@ -15,6 +15,7 @@ project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). computation, as it is already part of parameter `kh_0`. - Mutating BMI model control functions (`update`, `update_until` and `finalize`) and extended mutating BMI functions (`load_state` and `save_state`) should return `nothing`. +- Added downloading of testdata to Dockerfile, to ensure an image was able to build. ### Changed - Removed vertical concepts `HBV` and `FLEXTopo`.