Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Validation settings additional support #1352

Open
JoerivanEngelen opened this issue Dec 18, 2024 · 0 comments
Open

[FEATURE] - Validation settings additional support #1352

JoerivanEngelen opened this issue Dec 18, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@JoerivanEngelen
Copy link
Contributor

There is a ValidationContext which stores validation settings. Currently constructing a simulation with Modflow6Simulation.from_imod5_data turns off the strict checks for the well and hfb packages.

As noticed before in this PR #1351, this becomes problematic when doing the following:

  • Import iMOD5 Simulation
  • Dump to netcdfs + toml
  • Load dumped simulation

Users can workaround this by doing the following, but this requires setting semi-private attributes:

simulation = imod.mf6.Modflow6Simulation("my_simulation")
simulation._validation_context.strict_hfb_validation = False

The following would enhance configurability:

  • Make sure they are dumped to file as well and loaded again.
  • Allow turning off this specific validation with a setter method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📯 New
Development

No branches or pull requests

1 participant