Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-section widget: Plotted cross-section data not redrawn after switching time #72

Closed
JoerivanEngelen opened this issue Mar 12, 2024 · 2 comments · Fixed by #76
Closed
Assignees
Labels
bug Something isn't working

Comments

@JoerivanEngelen
Copy link
Contributor

@rubencalje reported in #65:

From the docs:

For time dependent data, when the Temporal Controller Panel is turned on, the cross-section plot is automatically updated when a different moment in time is selected.

His experience:

This is not my experience. The cross-section plot only updates to a new selected time when I draw another cross-section line using the "Select location"-button. The main map does update when I select a different moment in time. Is this a known issue, or am I doing something wrong?

So it appears data is not automatically redrawn when selecting different timestamps.

@JoerivanEngelen
Copy link
Contributor Author

Some triage is required: @rubencalje, have you tested if this was only the case with line data or also with the PColorMesh data (i.e. "as line data" checked off?). I'm not sure I have tested the plugin for transient line data. It could also be that something changed internally in QGIS which breaks this, which QGIS version are you using?

@JoerivanEngelen JoerivanEngelen moved this to 🤝 Accepted in iMOD Suite Mar 12, 2024
@JoerivanEngelen JoerivanEngelen added the bug Something isn't working label Mar 12, 2024
@rubencalje
Copy link
Contributor

Thanks for generating a separate issue.

I just checked. You are right, this issue is only the case when the data is drawn as lines. When the data is draws as PColorMesh data the plot is updated when the selected time is changed.

I have tested this in QGIS version 3.32.0-Lima.

@JoerivanEngelen JoerivanEngelen self-assigned this Mar 13, 2024
@JoerivanEngelen JoerivanEngelen moved this from 🤝 Accepted to 🧐 In Review in iMOD Suite Mar 13, 2024
JoerivanEngelen added a commit that referenced this issue Mar 18, 2024
* First version of fix with code duplication

* Refactor to use Mixins

* fix docstring

* Refactor duplicate code away in SupportsTemporalMixin and fix bug in its requires_loading() method, which would return False if different cross-section was drawn but same timestep selected

* Update changelog

* Add comment
@github-project-automation github-project-automation bot moved this from 🧐 In Review to ✅ Done in iMOD Suite Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants