Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use h5netcdf instead of netCDF4 in exchange logging #321

Open
Huite opened this issue Aug 15, 2024 · 2 comments
Open

Use h5netcdf instead of netCDF4 in exchange logging #321

Huite opened this issue Aug 15, 2024 · 2 comments

Comments

@Huite
Copy link
Contributor

Huite commented Aug 15, 2024

I noticed this imports netCDF4:

I recommend using h5netcdf instead. We were having problems with netCDF4 before (and problems keep appearing now and then to be honest). I think h5netcdf is smaller too and results in a smaller pyinstaller bundle. It can be a bit faster too.

I thought I had made a change like this before, but I cannot find any commits...

@Huite
Copy link
Contributor Author

Huite commented Aug 15, 2024

It was this:

#171

Did this get reverted somehow?

@Huite
Copy link
Contributor Author

Huite commented Aug 15, 2024

This PR puts netCDF4 back: https://github.com/Deltares/imod_coupler/pull/286/files

Was that a conscious decision?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant