chore: Omnichannel QoL improvements (RocketChat#34865)

Devansht420 · Jan 21, 2025 · 5261f03 · 5261f03
1 parent a5b4584
commit 5261f03
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 14 deletions.
diff --git a/apps/meteor/ee/app/livechat-enterprise/server/hooks/index.ts b/apps/meteor/ee/app/livechat-enterprise/server/hooks/index.ts
@@ -27,3 +27,4 @@ import './sendPdfTranscriptOnClose';
 import './applyRoomRestrictions';
 import './afterTagRemoved';
 import './manageDepartmentUnit';
+import './autoCloseQueued';
diff --git a/apps/meteor/ee/app/livechat-enterprise/server/hooks/onCloseLivechat.ts b/apps/meteor/ee/app/livechat-enterprise/server/hooks/onCloseLivechat.ts
@@ -1,7 +1,6 @@
 import type { IOmnichannelRoom } from '@rocket.chat/core-typings';
-import { LivechatRooms, Subscriptions } from '@rocket.chat/models';
+import { LivechatRooms } from '@rocket.chat/models';
 
-import { notifyOnSubscriptionChangedByRoomId } from '../../../../../app/lib/server/lib/notifyListener';
 import { settings } from '../../../../../app/settings/server';
 import { callbacks } from '../../../../../lib/callbacks';
 import { AutoCloseOnHoldScheduler } from '../lib/AutoCloseOnHoldScheduler';
@@ -17,14 +16,9 @@ const onCloseLivechat = async (params: LivechatCloseCallbackParams) => {
 		room: { _id: roomId },
 	} = params;
 
-	const responses = await Promise.all([
-		LivechatRooms.unsetOnHoldByRoomId(roomId),
-		Subscriptions.unsetOnHoldByRoomId(roomId),
-		AutoCloseOnHoldScheduler.unscheduleRoom(roomId),
-	]);
-
-	if (responses[1].modifiedCount) {
-		void notifyOnSubscriptionChangedByRoomId(roomId);
+	await LivechatRooms.unsetOnHoldByRoomId(roomId);
+	if (settings.get('Livechat_auto_close_on_hold_chats_timeout')) {
+		await AutoCloseOnHoldScheduler.unscheduleRoom(roomId);
 	}
 
 	if (!settings.get('Livechat_waiting_queue')) {
@@ -41,5 +35,5 @@ callbacks.add(
 	'livechat.closeRoom',
 	(params: LivechatCloseCallbackParams) => onCloseLivechat(params),
 	callbacks.priority.HIGH,
-	'livechat-waiting-queue-monitor-close-room',
+	'livechat-on-close-livechat-remove-on-hold-and-dispatch-waiting-queue',
 );
diff --git a/apps/meteor/ee/app/livechat-enterprise/server/hooks/onLoadConfigApi.ts b/apps/meteor/ee/app/livechat-enterprise/server/hooks/onLoadConfigApi.ts
@@ -6,9 +6,7 @@ callbacks.add(
 	async (options) => {
 		const { room } = options;
 
-		const queueInfo = await getLivechatQueueInfo(room);
-		const customFields = await getLivechatCustomFields();
-
+		const [queueInfo, customFields] = await Promise.all([getLivechatQueueInfo(room), getLivechatCustomFields()]);
 		return {
 			...(queueInfo && { queueInfo }),
 			...(customFields && { customFields }),