fix: special characters not escaped on sidepanel extended view (Rocke…

…tChat#34000)
Devansht420 · Dec 13, 2024 · 75643e1 · 75643e1
1 parent eb794b7
commit 75643e1
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/.changeset/tidy-boxes-hide.md b/.changeset/tidy-boxes-hide.md
@@ -0,0 +1,5 @@
+---
+'@rocket.chat/meteor': patch
+---
+
+Fixes special characters not being escaped on sidepanel extended view
diff --git a/apps/meteor/client/views/room/Sidepanel/hooks/useItemData.tsx b/apps/meteor/client/views/room/Sidepanel/hooks/useItemData.tsx
@@ -48,7 +48,7 @@ export const useItemData = (
 			time,
 			badges,
 			avatar: AvatarTemplate && <AvatarTemplate {...room} />,
-			subtitle: message,
+			subtitle: message ? <span className='message-body--unstyled' dangerouslySetInnerHTML={{ __html: message }} /> : null,
 		}),
 		[AvatarTemplate, badges, highlighted, icon, message, openedRoom, room, time],
 	);

diff --git a/apps/meteor/tests/e2e/feature-preview.spec.ts b/apps/meteor/tests/e2e/feature-preview.spec.ts
@@ -254,8 +254,7 @@ test.describe.serial('feature preview', () => {
 			await expect(poHomeChannel.sidepanel.getExtendedItem(sidepanelTeam, message)).toBeVisible();
 		});
 
-		// remove .fail after fix
-		test.fail('should escape special characters on item subtitle', async ({ page }) => {
+		test('should escape special characters on item subtitle', async ({ page }) => {
 			await page.goto('/home');
 			const message = 'hello > world';
 			const parsedWrong = 'hello &gt; world';