Harmonise stratigraphy DD-179 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed. |
|
I know about the duplication and I try to kept it to a minimum (by for example creating the abstractChronostratigraphy class for shared methods). However, I would like to keep a separate class for each term so we can easily change the local if we need more specific logic for that specific term. Also when additional data models come in we can house specific logic in the term class. This means that we will have Terms which only call super methods with specific parameters, they look-a-like a lot but there is no logic getting duplicated (or there shouldn't be) |
southeo
approved these changes
Mar 6, 2023
...ore/translator/terms/specimen/stratigraphy/biostratigraphic/HighestBiostratigraphicZone.java
Show resolved
Hide resolved
.../translator/terms/specimen/stratigraphy/chronostratigraphic/EarliestEpochOrLowestSeries.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Stratigraphy terms:
See JIRA ticket: