From 614ae19edaf05fc7f2de6f0c0964a92b958c812d Mon Sep 17 00:00:00 2001
From: southeo <soulaine.theo@gmail.com>
Date: Wed, 6 Dec 2023 13:24:02 +0100
Subject: [PATCH] Logs and patch endpoint

---
 .../dissco/core/handlemanager/controller/PidController.java | 6 +++---
 .../eu/dissco/core/handlemanager/service/HandleService.java | 1 +
 .../eu/dissco/core/handlemanager/service/PidService.java    | 2 ++
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/main/java/eu/dissco/core/handlemanager/controller/PidController.java b/src/main/java/eu/dissco/core/handlemanager/controller/PidController.java
index f13d5f31..59296149 100644
--- a/src/main/java/eu/dissco/core/handlemanager/controller/PidController.java
+++ b/src/main/java/eu/dissco/core/handlemanager/controller/PidController.java
@@ -99,7 +99,7 @@ public ResponseEntity<JsonApiWrapperWrite> searchByPrimarySpecimenObjectId(
   }
 
   @Operation(summary = "Create single PID Record")
-  @PostMapping(value = "")
+  @PostMapping(value = "/")
   public ResponseEntity<JsonApiWrapperWrite> createRecord(@RequestBody JsonNode request,
       Authentication authentication)
       throws PidResolutionException, InvalidRequestException, PidCreationException {
@@ -147,7 +147,7 @@ public ResponseEntity<JsonApiWrapperWrite> updateRecord(@PathVariable("prefix")
   }
 
   @Operation(summary = "Update multiple PID Records")
-  @PatchMapping(value = "")
+  @PatchMapping(value = "/")
   public ResponseEntity<JsonApiWrapperWrite> updateRecords(@RequestBody List<JsonNode> requests,
       Authentication authentication)
       throws InvalidRequestException, PidResolutionException, UnprocessableEntityException {
@@ -229,7 +229,7 @@ public ResponseEntity<Void> rollbackHandlePhysId(
 
 
   @Operation(summary = "Archive multiple PID records")
-  @PutMapping(value = "")
+  @PutMapping(value = "/")
   public ResponseEntity<JsonApiWrapperWrite> archiveRecords(@RequestBody List<JsonNode> requests,
       Authentication authentication)
       throws InvalidRequestException, PidResolutionException, UnprocessableEntityException {
diff --git a/src/main/java/eu/dissco/core/handlemanager/service/HandleService.java b/src/main/java/eu/dissco/core/handlemanager/service/HandleService.java
index b92d565b..6de07285 100644
--- a/src/main/java/eu/dissco/core/handlemanager/service/HandleService.java
+++ b/src/main/java/eu/dissco/core/handlemanager/service/HandleService.java
@@ -65,6 +65,7 @@ public JsonApiWrapperWrite createRecords(List<JsonNode> requests)
         default -> throw new UnsupportedOperationException("Unrecognized type");
       }
     } catch (JsonProcessingException | PidResolutionException e) {
+      log.error("An error has occurred in processing request", e);
       throw new InvalidRequestException(
           "An error has occurred parsing a record in request. More information: " + e.getMessage());
     }
diff --git a/src/main/java/eu/dissco/core/handlemanager/service/PidService.java b/src/main/java/eu/dissco/core/handlemanager/service/PidService.java
index 79b71991..b3272e19 100644
--- a/src/main/java/eu/dissco/core/handlemanager/service/PidService.java
+++ b/src/main/java/eu/dissco/core/handlemanager/service/PidService.java
@@ -304,6 +304,8 @@ protected void verifyNoRegisteredSpecimens(List<byte[]> physicalIds)
     if (!registeredRows.isEmpty()) {
       var registeredHandles = registeredRows.stream()
           .map(row -> new String(row.getHandle(), StandardCharsets.UTF_8)).toList();
+      log.error("Attempting to register identifiers for existing records");
+      log.debug("Handles already registered: {}", registeredHandles);
       throw new PidResolutionException(
           "Unable to create PID records. Some requested records are already registered. Verify the following digital specimens:"
               + registeredHandles);