Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/schema library #69

Merged
merged 15 commits into from
Dec 14, 2023
Merged

Feature/schema library #69

merged 15 commits into from
Dec 14, 2023

Conversation

southeo
Copy link
Contributor

@southeo southeo commented Dec 12, 2023 •
edited
Loading

  • Adds deployment for schemas to be posted at schema.dissco.tech
  • Adds schemas for base fdo profiles (DOI and Handle Kernels)
  • Include versioning in file system

DiSSCo/dissco-core-deployment#31

TomDijkema
TomDijkema reviewed Dec 12, 2023
View reviewed changes
data-model/Dockerfile Outdated Show resolved Hide resolved
samleeflang
samleeflang reviewed Dec 13, 2023
View reviewed changes
Copy link
Contributor

@samleeflang samleeflang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Great that the FDO records are added as well 🎉
Have a couple questions and comments

data-model/Dockerfile Outdated Show resolved Hide resolved
data-model/Dockerfile Outdated Show resolved Hide resolved
data-model/Dockerfile Outdated Show resolved Hide resolved
data-model/fdo-profiles/0.1.0/digital-specimen/schema/digital-specimen.json Outdated Show resolved Hide resolved
data-model/fdo-profiles/0.1.0/digital-specimen/schema/digital-specimen.json Outdated Show resolved Hide resolved
data-model/nginx/nginx.conf Show resolved Hide resolved
data-model/nginx/nginx.conf Outdated Show resolved Hide resolved
@southeo southeo requested a review from samleeflang December 13, 2023 09:55
@southeo southeo merged commit 8b96f0b into master Dec 14, 2023
1 check passed
@southeo southeo deleted the feature/schema-library branch December 14, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomDijkema TomDijkema TomDijkema left review comments

@samleeflang samleeflang samleeflang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@southeo @samleeflang @TomDijkema