Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flake8 output on Savu's py37 repo #692

Open
dkazanc opened this issue Dec 9, 2020 · 1 comment
Open

Flake8 output on Savu's py37 repo #692

dkazanc opened this issue Dec 9, 2020 · 1 comment

Comments

@dkazanc
Copy link
Collaborator

dkazanc commented Dec 9, 2020

probably needs to be fixed for Github Actions: It's a good practice to use flake8 and make lint free code.

Wed, 09 Dec 2020 11:22:01 GMT ./savu/data/chunking.py:287:12: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT         if direction is 'up':
Wed, 09 Dec 2020 11:22:01 GMT            ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/data/data_structures/data_create.py:69:12: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT         if len(args) is 1:
Wed, 09 Dec 2020 11:22:01 GMT            ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/data/data_structures/data_create.py:144:16: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT             if name is '*':
Wed, 09 Dec 2020 11:22:01 GMT                ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/data/data_structures/data_create.py:215:16: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT             if len(arg.split('.')) is 1:
Wed, 09 Dec 2020 11:22:01 GMT                ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/data/data_structures/data_create.py:219:20: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT                 if len(arg.split('~')) is 1:
Wed, 09 Dec 2020 11:22:01 GMT                    ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/data/data_structures/data_add_ons.py:100:12: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT         if len(pad_vals) is 3:
Wed, 09 Dec 2020 11:22:01 GMT            ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/data/data_structures/data_add_ons.py:125:16: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT             if sum(self.padding_dirs[key].values()) is 0:
Wed, 09 Dec 2020 11:22:01 GMT                ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/data/data_structures/data_add_ons.py:136:16: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT             if sum(self.padding_dirs[key].values()) is 0:
Wed, 09 Dec 2020 11:22:01 GMT                ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/data/data_structures/data.py:322:12: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT         if check is 2 and len(self.get_shape()) > 2:
Wed, 09 Dec 2020 11:22:01 GMT            ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/data/data_structures/data.py:325:14: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT         elif check is 1:
Wed, 09 Dec 2020 11:22:01 GMT              ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/data/data_structures/data.py:369:30: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT         n1 = 'PROJECTION' if pname is 'SINOGRAM' else 'SINOGRAM'
Wed, 09 Dec 2020 11:22:01 GMT                              ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/data/data_structures/data_types/data_plus_darks_and_flats.py:115:24: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT         return data if len(data.shape) is 2 else \
Wed, 09 Dec 2020 11:22:01 GMT             data.mean(self.proj_dim).astype(np.float32)
Wed, 09 Dec 2020 11:22:01 GMT                        ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/data/data_structures/data_types/data_plus_darks_and_flats.py:178:12: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT         if len(data.shape) is 2:
Wed, 09 Dec 2020 11:22:01 GMT            ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/core/utils.py:221:5: F821 undefined name 'msg'
Wed, 09 Dec 2020 11:22:01 GMT     msg['Subject'] = 'Your Savu job has completed'
Wed, 09 Dec 2020 11:22:01 GMT     ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/core/utils.py:222:5: F821 undefined name 'msg'
Wed, 09 Dec 2020 11:22:01 GMT     msg['From'] = me
Wed, 09 Dec 2020 11:22:01 GMT     ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/core/utils.py:223:5: F821 undefined name 'msg'
Wed, 09 Dec 2020 11:22:01 GMT     msg['To'] = you
Wed, 09 Dec 2020 11:22:01 GMT     ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/core/utils.py:228:27: F821 undefined name 'msg'
Wed, 09 Dec 2020 11:22:01 GMT     s.sendmail(me, [you], msg.as_string('write something here'))
Wed, 09 Dec 2020 11:22:01 GMT                           ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/core/transport_setup.py:41:12: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT         if len(processes) is 1:
Wed, 09 Dec 2020 11:22:01 GMT            ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/core/transports/basic_transport.py:57:12: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT         if self.n_plugins is not 1:
Wed, 09 Dec 2020 11:22:01 GMT            ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/core/transports/base_transport.py:465:16: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT             if link_type is 'final_result':
Wed, 09 Dec 2020 11:22:01 GMT                ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/core/transports/dosna_transport.py:110:12: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT         if self.n_plugins is not 1:
Wed, 09 Dec 2020 11:22:01 GMT            ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/core/transports/dosna_transport.py:146:12: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT         if current_and_next is 0:
Wed, 09 Dec 2020 11:22:01 GMT            ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/plugins/centering/vo_centering_iterative.py:167:42: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT         smin, smax = self.search_area if self.get_iteration() is 0 \
Wed, 09 Dec 2020 11:22:01 GMT             else self._expand_search()
Wed, 09 Dec 2020 11:22:01 GMT                                          ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/plugins/corrections/dark_flat_field_correction.py:98:12: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT         if len(full_shape) is 3:
Wed, 09 Dec 2020 11:22:01 GMT            ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/plugins/savers/utils/hdf5_utils.py:151:14: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT         elif current_and_next is 0:
Wed, 09 Dec 2020 11:22:01 GMT              ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/plugins/loaders/multi_savu_loader.py:110:16: F821 undefined name 'SavuLoader'
Wed, 09 Dec 2020 11:22:01 GMT         savu = SavuLoader()
Wed, 09 Dec 2020 11:22:01 GMT                ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/plugins/loaders/mapping_loaders/p2r_fly_scan_detector_loader.py:74:16: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT             if len(data_obj.data.shape) is 3:
Wed, 09 Dec 2020 11:22:01 GMT                ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/plugins/loaders/mapping_loaders/i14_loaders/i14_fluo_loader.py:62:20: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT                 if axis is not '.':
Wed, 09 Dec 2020 11:22:01 GMT                    ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/plugins/loaders/mapping_loaders/i14_loaders/i14_fluo_loader.py:72:20: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT                 if axis is not '.':
Wed, 09 Dec 2020 11:22:01 GMT                    ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/plugins/loaders/mapping_loaders/i08_loaders/i08_fluo_loader.py:62:20: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT                 if axis is not '.':
Wed, 09 Dec 2020 11:22:01 GMT                    ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/plugins/loaders/mapping_loaders/i08_loaders/i08_fluo_loader.py:72:20: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT                 if axis is not '.':
Wed, 09 Dec 2020 11:22:01 GMT                    ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/plugins/loaders/full_field_loaders/mrc_loader.py:62:12: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT         if nDims is 3:
Wed, 09 Dec 2020 11:22:01 GMT            ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/plugins/loaders/full_field_loaders/mrc_loader.py:74:14: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT         elif nDims is 4:
Wed, 09 Dec 2020 11:22:01 GMT              ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/plugins/reshape/data_removal.py:89:16: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT             if len(indices_list) is 2:
Wed, 09 Dec 2020 11:22:01 GMT                ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/plugins/ring_removal/ring_removal_waveletfft.py:65:12: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT         if len(sino_shape) is 3:
Wed, 09 Dec 2020 11:22:01 GMT            ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/plugins/reconstructions/base_recon.py:105:12: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT         if len(self.angles.shape) is not 1:
Wed, 09 Dec 2020 11:22:01 GMT            ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/plugins/reconstructions/astra_recons/base_astra_vector_recon.py:50:12: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT         if len(out_dataset) is 2:
Wed, 09 Dec 2020 11:22:01 GMT            ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/plugins/visualisation/ortho_slice.py:112:16: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT             if ext is not 'None':
Wed, 09 Dec 2020 11:22:01 GMT                ^
Wed, 09 Dec 2020 11:22:01 GMT ./savu/test/test_utils.py:118:8: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT     if n_out is 'var':
Wed, 09 Dec 2020 11:22:01 GMT        ^
Wed, 09 Dec 2020 11:22:01 GMT ./scripts/citation_extractor/citation_extractor.py:83:8: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT     if len(args) is not 2:
Wed, 09 Dec 2020 11:22:01 GMT        ^
Wed, 09 Dec 2020 11:22:01 GMT ./scripts/config_generator/content.py:288:16: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT             if len(entry) is 2:
Wed, 09 Dec 2020 11:22:01 GMT                ^
Wed, 09 Dec 2020 11:22:01 GMT ./scripts/config_generator/content.py:289:20: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT                 if len(pos_list[start]) is 2:
Wed, 09 Dec 2020 11:22:01 GMT                    ^
Wed, 09 Dec 2020 11:22:01 GMT ./scripts/config_generator/content.py:304:12: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT         if len(entry) is 2:
Wed, 09 Dec 2020 11:22:01 GMT            ^
Wed, 09 Dec 2020 11:22:01 GMT ./scripts/config_generator/content.py:343:12: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT         if len(entry) is 1:
Wed, 09 Dec 2020 11:22:01 GMT            ^
Wed, 09 Dec 2020 11:22:01 GMT ./scripts/config_generator/completer.py:95:27: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT         if not args[0] or len(args) is 2:
Wed, 09 Dec 2020 11:22:01 GMT                           ^
Wed, 09 Dec 2020 11:22:01 GMT ./scripts/config_generator/config_utils.py:101:16: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT             if error_level is 0 and savu_error:
Wed, 09 Dec 2020 11:22:01 GMT                ^
Wed, 09 Dec 2020 11:22:01 GMT ./scripts/config_generator/config_utils.py:103:18: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT             elif error_level is 0:
Wed, 09 Dec 2020 11:22:01 GMT                  ^
Wed, 09 Dec 2020 11:22:01 GMT ./scripts/config_generator/config_utils.py:105:18: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT             elif error_level is 1:
Wed, 09 Dec 2020 11:22:01 GMT                  ^
Wed, 09 Dec 2020 11:22:01 GMT ./scripts/log_evaluation/GraphicalThreadProfiler_multi.py:118:8: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT     if len(filename[0].split('/')) is 0:
Wed, 09 Dec 2020 11:22:01 GMT        ^
Wed, 09 Dec 2020 11:22:01 GMT ./scripts/log_evaluation/template_strings.py:69:24: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT     plot_per_x = (1 if nVals is 1 else 2)
Wed, 09 Dec 2020 11:22:01 GMT                        ^
Wed, 09 Dec 2020 11:22:01 GMT ./scripts/log_evaluation/VisualiseProfileData.py:64:45: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT     single_files = [f for f in all_files if f.split('.')[-1][0] is 'o']
Wed, 09 Dec 2020 11:22:01 GMT                                             ^
Wed, 09 Dec 2020 11:22:01 GMT ./scripts/log_evaluation/VisualiseProfileData.py:105:8: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT     if len(args) is 1:
Wed, 09 Dec 2020 11:22:01 GMT        ^
Wed, 09 Dec 2020 11:22:01 GMT ./scripts/log_evaluation/VisualiseProfileData.py:106:36: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT         filename = (os.getcwd() if args[0] is '.' else args[0])
Wed, 09 Dec 2020 11:22:01 GMT                                    ^
Wed, 09 Dec 2020 11:22:01 GMT 48    F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple)
Wed, 09 Dec 2020 11:22:01 GMT 5     F821 undefined name 'msg'
Wed, 09 Dec 2020 11:22:01 GMT 53
Wed, 09 Dec 2020 11:22:01 GMT Error: Process completed with exit code 1.
@dkazanc
Copy link
Collaborator Author

dkazanc commented Dec 9, 2020

a useful command to be applied to your new piece of code
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
Probably too much to fix all this stuff now but may be taking care for new plugins?

@dkazanc dkazanc mentioned this issue Dec 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dkazanc