Incorrect place for NXtomo value in tomo_standard.nxs internal structure

[yousefmoazzam]

From the NXtomo application definition, the definition field should be a direct child of the NXentry. However, in tomo_standard.nxs, it looks like the definition field is typo-ed to defination and is nested further down within /entry1/tomo_entry than it should be:

[twi18192@pc0074 httomo (main)]$ h5dump -a /entry1/tomo_entry/definition tests/test_data/tomo_standard.nxs
HDF5 "tests/test_data/tomo_standard.nxs" {
ATTRIBUTE "definition" {h5dump error: unable to open attribute "definition"

}
}
[twi18192@pc0074 httomo (main)]$ h5dump -a /entry1/tomo_entry/data/defination tests/test_data/tomo_standard.nxs
HDF5 "tests/test_data/tomo_standard.nxs" {
ATTRIBUTE "defination" {
   DATATYPE  H5T_STRING {
      STRSIZE H5T_VARIABLE;
      STRPAD H5T_STR_NULLTERM;
      CSET H5T_CSET_UTF8;
      CTYPE H5T_C_S1;
   }
   DATASPACE  SCALAR
   DATA {
   (0): "NXtomo"
   }
}
}

[yousefmoazzam]

One more issue with tomo_standard.nxs is that I think the definition should be a dataset rather than an attribute, after seeing how data from beamlines with an NXtomo have the definition as a dataset, not an attribute.

For example, see the following I12 file (note the use of -d not -a in the h5dump command in order to successfully inspect it):

[twi18192@pc0074 docs (tomo-entry-discovery)]$ h5dump -a /entry1/tomo_entry/definition /dls/i12/data/2025/mg37177-1/rawdata/157544.nxs
HDF5 "/dls/i12/data/2025/mg37177-1/rawdata/157544.nxs" {
ATTRIBUTE "definition" {h5dump error: unable to open attribute "definition"

}
}
[twi18192@pc0074 docs (tomo-entry-discovery)]$ h5dump -d /entry1/tomo_entry/definition /dls/i12/data/2025/mg37177-1/rawdata/157544.nxs
HDF5 "/dls/i12/data/2025/mg37177-1/rawdata/157544.nxs" {
DATASET "/entry1/tomo_entry/definition" {
   DATATYPE  H5T_STRING {
      STRSIZE H5T_VARIABLE;
      STRPAD H5T_STR_NULLTERM;
      CSET H5T_CSET_UTF8;
      CTYPE H5T_C_S1;
   }
   DATASPACE  SCALAR
   DATA {
   (0): "NXtomo"
   }
}
}