Add box for custom css in heads up display admin settings page #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apjmason
requested changes
Oct 29, 2024
There was a problem hiding this comment.
@wrkzk this is looking good for your specific CSS changes, but the plugin is still throwing an error on install due to a PHP behavior change, e.g.
Warning: Trying to access array offset on value of type bool in /home/.../wp-content/plugins/WP-Heads-Up-Plugin/core-functions.php on line 57
Can you uninstall then reinstall to test this behavior and try to fix? The basic issue is that it's returning false when there is no value yet in the table, instead of empty or null. A few possible fixes discussed here that you can experiment with
Co-authored-by: Austin Mason <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds in a html textarea box where site admins can add custom css that will be injected into the heads up display that is shown on the dashboard.