Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICAO Implementation differs from test implementation #209

Closed
jona7o opened this issue Dec 8, 2021 · 2 comments
Closed

ICAO Implementation differs from test implementation #209

jona7o opened this issue Dec 8, 2021 · 2 comments

Comments

@jona7o
Copy link

jona7o commented Dec 8, 2021

Hi,

we are a software development company with a product for COVID19 test- and vaccination centers. For this use case we create both, vaccination certificates over ubirch/ibm api and test certificates over the cwa endpoint. Today I found a miss match between these two certificates for the same input.

I think this bug is located in the ubirch/ibm api because i think the dot char "." is not specified for a machine readable string and gets replaced by nothing and not with an "<" char. If it is defined this is a bug in the reference implementation of the cwa. I'll open these requests in both github repositorys and link each other. Could someone clarify which implementation is correct?

Example for Vaccination certificates with Ubirch/IBM API:
"fn": "Dr. Mustermann",
"gn": "Max",
"fnt": "DR<<MUSTERMANN",
"gnt": "MAX"

Example for Test over CWA API
"fn": "Dr. Mustermann",
"gn": "Max",
"fnt": "DR<MUSTERMANN",
"gnt": "MAX"

Regards, Tobias

corona-warn-app/cwa-quicktest-onboarding#68

@jona7o jona7o changed the title Bug in ICAO String Generation ICAO Implementation differs from test implementation Dec 8, 2021
@thinkberg
Copy link
Contributor

This is a bug. Dots should be omitted. I will forward it to our devs.

@vaubaehn
Copy link

vaubaehn commented Feb 2, 2022

Hi @jona7o ,

I'm following issues with ICAO transliterations as it causes problems when there's a mismatch of associating DCCs to one person by their standardized names.
I'm a bit late with my question, but would be happy if you replied:
You are writing that you're creating test certificates via the CWA API. I assume you are referring to the backend of TSI's Schnelltestportal? If yes, then you coded the ICAO transliteration yourself I guess?
When you are referring to

reference implementation of the cwa

what do you mean concretely?

Your repsonse could help to move on in the issue of harmonizing ICAO transliterations across different implementations in the overall-workflow of DCCs associated with TSI (RAT portal & backend API partners), and Ubirch: corona-warn-app/cwa-quick-test-frontend#185 (comment)

Thanks very much in advance,
v.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants