Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dataset class to sample from #10

Open
thomaswolgast opened this issue Nov 1, 2024 · 2 comments · May be fixed by #32
Open

Add dataset class to sample from #10

thomaswolgast opened this issue Nov 1, 2024 · 2 comments · May be fixed by #32
Labels
enhancement New feature or request

Comments

@thomaswolgast
Copy link
Member

The idea is that the user can provide arbitrary custom datasets to the env. That makes the framework more modular and the base env class leaner. The Dataset class should be compatible with simbench profiles.
@thomaswolgast thomaswolgast added the enhancement New feature or request label Nov 1, 2024
@thomaswolgast
Copy link
Member Author

Approach implemented in https://github.com/Digitalized-Energy-Systems/opfgym/tree/10-add-dataset-class-to-sample-from. However, not convinced this is the right way. Makes many things more complicated and maybe more difficult to understand for users?

@thomaswolgast thomaswolgast mentioned this issue Nov 15, 2024
Open
@thomaswolgast
Copy link
Member Author

Part of bigger issue #25

@thomaswolgast thomaswolgast mentioned this issue Nov 18, 2024
Closed
@thomaswolgast thomaswolgast linked a pull request Dec 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@thomaswolgast