Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text in Acknowledgements Rows #144

Open
Jerrot opened this issue May 17, 2020 · 5 comments
Open

Text in Acknowledgements Rows #144

Jerrot opened this issue May 17, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@Jerrot
Copy link

Jerrot commented May 17, 2020

In the German translation of the current release (1.3), I can see a different text behaviour in the About -> Acknowledgements (“Danksagungen”) section. While the first row ends with an ellipsis glyph (UIKit speech: .byTruncatingTail), the others - e.g. third and last row - just happily line-break.

E106283E-277D-4497-A682-B153BA66A0EC

@TheVaan
Copy link
Collaborator

TheVaan commented May 17, 2020

Danke für den Hinweis! Da hab ich wohl auch eine Übersetzung übersehen. Ich schaue es mir mal an.

@TheVaan
Copy link
Collaborator

TheVaan commented May 17, 2020

Hey @Dimillian, you may take a look here: there is no truncating in makeRow but for some reason, contributor entry is truncated

Dimillian pushed a commit that referenced this issue May 17, 2020
- small refactoring
- corrected typo
- added German translation
@ericlewis ericlewis added the bug Something isn't working label May 18, 2020
@Jerrot
Copy link
Author

Jerrot commented May 23, 2020

Not fixed though. Anyway, I think it might be a SwiftUI bug actually and mostly I was curious. :)

@Dimillian Dimillian reopened this May 23, 2020
@Dimillian
Copy link
Owner

I thought I fixed it... yeah so I think I have to set a width or numberOfLines I'll take another look.

@TheVaan
Copy link
Collaborator

TheVaan commented May 23, 2020

Maybe the problem is, that the text fits inside the line but the > overlaps, so the word get truncated. The rows where it breaks line correctly doesn’t fit in a single line so line break is necessary.

ericlewis pushed a commit to ericlewis/ACHNBrowserUI that referenced this issue May 26, 2020
- small refactoring
- corrected typo
- added German translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants