[Docs]: Update Docs for Proper #[layout] and #[end_layout] Macros Usage in Enums

[wiseaidev]

Hiya ( ´ ω ` )ノﾞ,

This is not a critical issue, but I’ve noticed a bug with layout and routes ordering when defining multiple layouts for different pages.

Here’s an example that works:

#[derive(Clone, Routable, Debug, PartialEq, Serialize, Deserialize)]  
pub enum Route {  
    #[layout(HomeNavBar)]  
    #[route("/")]  
    Home {},  
    #[end_layout]  

    #[layout(LoginNavBar)]  
    #[route("/login")]  
    Login {},  
    #[end_layout]  

    #[route("/dashboard")]  
    Dashboard {},  
}  

However, if you reorder the routes like this:

#[derive(Clone, Routable, Debug, PartialEq, Serialize, Deserialize)]  
pub enum Route {  
    #[layout(HomeNavBar)]  
    #[route("/")]  
    Home {},  
    #[end_layout]

    #[route("/dashboard")] // Notice this route between the layouts  
    Dashboard {},  

    #[layout(LoginNavBar)]  
    #[route("/login")]  
    Login {},  
    #[end_layout]  
}  

The routing doesn’t work as expected.

Just wanted to raise this to your attention.

Best

[ealmloff]

I was not able to reproduce this issue with the git version of dioxus with either version of the router. Here is my attempt: https://github.com/ealmloff/fail-repo-3211

[wiseaidev]

I was not able to reproduce this issue with the git version of dioxus with either version of the router. Here is my attempt: https://github.com/ealmloff/fail-repo-3211

Thanks for the reply! But, your enum router example doesn't include a #[end_layout] macro at the end to close the corresponding #[layout] macro. In this case, it will raise:

error: expected identifier, found `}`
  --> src/main.rs:19:1
   |
4  | pub enum Route {  
   |          ----- while parsing this enum
...
19 | }  
   | ^ expected identifier
   |
   = help: enum variants can be `Variant`, `Variant = <integer>`, `Variant(Type, ..., TypeN)` or `Variant { fields: Types }`

  ❌ Build failed.
| 💼 Waiting to start building the project...                                   Error: 🚫 Serving project failed:

However, I realized that in Rust, macros are designed to modify the item or block immediately following them. Since #[end_layout] isn't attached to any item, it causes a bug. I think it is better to update the documentation to inform users that layouts must be properly scoped and ensure each #[layout] is correctly closed or inferred by the macro.