Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull out Manganis CLI support into a separate crate #3258

Closed
ealmloff opened this issue Nov 26, 2024 · 1 comment
Closed

Pull out Manganis CLI support into a separate crate #3258

ealmloff opened this issue Nov 26, 2024 · 1 comment
Labels
cli Related to the dioxus-cli program manganis Related to the manganis crate organization Layout of the repository

Comments

@ealmloff
Copy link
Member

ealmloff commented Nov 26, 2024

Refactor Request

The code to support manganis assets and asset optimization currently lives in the CLI (introduced in #3195). This means we don't need a stable API and it is fairly easy to integrate, but it makes it difficult to use manganis from other CLIs and it adds a lot of required dependencies to the CLI

It would be nice to pull out the optimization into a separate crate to make the CLI easier to maintain and could make it easier to move manganis optimization under a feature flag

@ealmloff ealmloff added cli Related to the dioxus-cli program organization Layout of the repository manganis Related to the manganis crate labels Nov 26, 2024
@jkelleyrtp
Copy link
Member

Oh forgot I did this - #3273

It's named specific to dioxus but could/should be renamed to something manganis-specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the dioxus-cli program manganis Related to the manganis crate organization Layout of the repository
Projects
None yet
Development

No branches or pull requests

2 participants