changed ColumnValueForUpdates to internal and instead Utils.convertColumn ensures correct properties are set, fixes #1

also allowed changing DropdownValue columns by dropdown item IDs

Author: Walkman100

MondayApi/Schema/Models/ColumnValues/BoardRelationValue.cs

@@ -20,8 +20,7 @@ public class BoardRelationValue : IMirroredValue, IColumnValue {
         public object Value { get; set; }
     }
 
-    [GraphQlObjectType("BoardRelationValue__unused")]
-    public class BoardRelationValueForUpdate : BoardRelationValue {
+    internal class BoardRelationValueForUpdate { // https://developer.monday.com/api-reference/reference/connect#json
         [JsonProperty("item_ids")]
         public ICollection<string> ItemIDs { get; set; }
     }

MondayApi/Schema/Models/ColumnValues/CheckboxValue.cs

@@ -14,7 +14,7 @@ public class CheckboxValue : IMirroredValue, IColumnValue {
         public object Value { get; set; }
     }
 
-    internal class CheckboxValueForUpdate {
-        public string Checked { get; set; } // see https://developer.monday.com/api-reference/docs/checkbox#json
+    internal class CheckboxValueForUpdate { // https://developer.monday.com/api-reference/reference/checkbox#json
+        public string Checked { get; set; }
     }
 }

MondayApi/Schema/Models/ColumnValues/DropdownValue.cs

@@ -11,8 +11,8 @@ public class DropdownValue : IMirroredValue, IColumnValue {
         public ICollection<DropdownValueOption> Values { get; set; }
     }
 
-    [GraphQlObjectType("DropdownValue__unused")]
-    public class DropdownValueForUpdate : DropdownValue { // see https://developer.monday.com/api-reference/docs/dropdown#json
+    internal class DropdownValueForUpdate { // https://developer.monday.com/api-reference/reference/dropdown#json
+        public ICollection<string> IDs { get; set; }
         public ICollection<string> Labels { get; set; }
     }
 }

MondayApi/Schema/Models/ColumnValues/PeopleValue.cs

@@ -16,8 +16,8 @@ public class PeopleValue : IMirroredValue, IColumnValue {
         public object Value { get; set; }
     }
 
-    internal class PeopleValueForUpdate {
-        [JsonProperty("personsAndTeams")] // see https://developer.monday.com/api-reference/docs/people#json
+    internal class PeopleValueForUpdate { // https://developer.monday.com/api-reference/reference/people#json
+        [JsonProperty("personsAndTeams")]
         public ICollection<PeopleEntity> PersonsAndTeams { get; set; }
     }
 }

MondayApi/Schema/Models/ColumnValues/PhoneValue.cs

@@ -16,9 +16,9 @@ public class PhoneValue : IMirroredValue, IColumnValue {
         public object Value { get; set; }
     }
 
-    [GraphQlObjectType("PhoneValue__unused")]
-    public class PhoneValueForUpdate : PhoneValue {
-        [JsonProperty("countryShortName")] // see https://developer.monday.com/api-reference/docs/phone#json
-        public new string CountryShortName { get; set; }
+    internal class PhoneValueForUpdate { // https://developer.monday.com/api-reference/reference/phone#json
+        public string Phone { get; set; }
+        [JsonProperty("countryShortName")]
+        public string CountryShortName { get; set; }
     }
 }

MondayApi/Utils/Utils.cs

@@ -36,11 +36,19 @@ private static object convertColumn(IColumnValue column) {
                         PersonsAndTeams = pv.PersonsAndTeams,
                     };
                 case BoardRelationValue bv:
-                    if (bv is BoardRelationValueForUpdate)
-                        return column;
                     return new BoardRelationValueForUpdate() {
                         ItemIDs = bv.LinkedItemIDs,
                     };
+                case PhoneValue pv:
+                    return new PhoneValueForUpdate() {
+                        Phone = pv.Phone,
+                        CountryShortName = pv.CountryShortName?.ToUpperInvariant(),
+                    };
+                case DropdownValue dv:
+                    return new DropdownValueForUpdate() {
+                        IDs = dv.Values.Select(v => v.ID).ToList(),
+                        Labels = dv.Values.Select(v => v.Label).ToList(),
+                    };
                 case CheckboxValue cv:
                     return cv.Checked.HasValue && cv.Checked.Value
                         ? new CheckboxValueForUpdate() { Checked = "true" }