feat: implement soundmojis #1281
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snipy7374
added
t: enhancement
shiftinv
reviewed
Feb 5, 2025
| @@ -1097,6 +1097,11 @@ class Message(Hashable): | |||
| The poll contained in this message. | |||
|
|
|||
| .. versionadded:: 2.10 | |||
|
|
|||
| soundboard_sounds: List[:class:`GuildSoundboardSound`] | |||
| A list of soundboard sounds in the message. | |||
There was a problem hiding this comment.
Suggested change
| A list of soundboard sounds in the message. | |
| A list of soundboard sounds in the message, | |
| if the message contains soundmojis. |
| @@ -1200,6 +1206,11 @@ def __init__( | |||
| except AttributeError: | |||
| self.guild = state._get_guild(utils._get_as_snowflake(data, "guild_id")) | |||
|
|
|||
| self.soundboard_sounds: List[GuildSoundboardSound] = [ | |||
| GuildSoundboardSound(data=d, state=state, guild_id=self.guild.id) | |||
There was a problem hiding this comment.
this won't necessarily be the same guild (or even from any guild at all), soundmojis can be from other guilds or default sounds.
Example message data snippets:
guild sound
"soundboard_sounds": [
{
"name": "test",
"sound_id": "123123",
"volume": 0.699999988079071,
"emoji_id": "456456",
"emoji_name": null,
"guild_id": "789789",
"available": true
}
],default sound
"soundboard_sounds": [
{
"name": "airhorn",
"sound_id": "2",
"volume": 1.0,
"emoji_id": null,
"emoji_name": "🔊",
"available": true
}
],| @@ -86,6 +86,14 @@ def created_at(self) -> Optional[datetime.datetime]: | |||
| return None | |||
| return snowflake_time(self.id) | |||
|
|
|||
| @property | |||
| def mention(self) -> str: | |||
There was a problem hiding this comment.
mention should be implemented on SoundboardSound and GuildSoundboardSound, but there isn't a use for it on partial sounds, as the guild data is just missing.
| @@ -1200,6 +1206,11 @@ def __init__( | |||
| except AttributeError: | |||
| self.guild = state._get_guild(utils._get_as_snowflake(data, "guild_id")) | |||
|
|
|||
| self.soundboard_sounds: List[GuildSoundboardSound] = [ | |||
There was a problem hiding this comment.
I think we should also handle this for message updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
pdm lintpdm pyright