Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider dropping setuptools #664

Open
onerandomusername opened this issue Jul 27, 2022 · 2 comments · May be fixed by #998
Open

Consider dropping setuptools #664

onerandomusername opened this issue Jul 27, 2022 · 2 comments · May be fixed by #998
Labels
feature request Request for a new feature p: low Low priority t: meta Changes to the project itself (CI, configs, etc.) t: refactor/typing/lint Refactors, typing changes and/or linting changes

Comments

@onerandomusername
Copy link
Member

Summary

Drop setuptools

What is the feature request for?

The core library

The Problem

Setuptools is no longer a great way of building python packages, there's quite a lot of room for error and mishaps. Overall, its not worth continuing to use when alternatives like poetry, hatch, pip-tools exist.

The Ideal Solution

drop setuptools, replace with a newer build backend

The Current Solution

No response

Additional Context

No response
@onerandomusername onerandomusername added feature request Request for a new feature p: low Low priority t: meta Changes to the project itself (CI, configs, etc.) t: refactor/typing/lint Refactors, typing changes and/or linting changes labels Jul 27, 2022
@onerandomusername onerandomusername moved this to Todo in disnake Jul 27, 2022
@shiftinv
Copy link
Member

What makes setuptools unsuitable for our purposes? Or rather, how are the other build backends better, is it actually worth it to switch? I currently don't see an issue with setuptools, but perhaps there are valid reasons to replace it.

@ironman9356
Copy link

I think poetry and/or pip has depreciated it too so Yuen’s this can be done
But I am not sure if there is any alternative for it Rn so if we just randomly remove it without a way to build the package it might not work

This was referenced Oct 28, 2022
Merged
Merged
@onerandomusername onerandomusername linked a pull request Apr 6, 2023 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Request for a new feature p: low Low priority t: meta Changes to the project itself (CI, configs, etc.) t: refactor/typing/lint Refactors, typing changes and/or linting changes
Projects
disnake
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: switch the build-backend to pdm-backend DisnakeDev/disnake
3 participants
@shiftinv @onerandomusername @ironman9356