fixed the issue #901 #908
Open
fixed the issue #901 #908
+28
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you add "fixes #901" to your description, it'll link up to the issue and automatically close it if this is merged. |
marksweb
reviewed
Aug 30, 2023
| "form_obj": form_obj, | ||
| }, | ||
| ) | ||
| except IntegrityError: |
There was a problem hiding this comment.
Although this fixes the issue, it assumes that any IntegrityError is caused by this issue. Now this may be true at the moment, but things may change. So we could merge this and catch this issue at this point.
There is some validation on the form that appears to be trying to check against this same constraint, and that is where I'd prefer the fix to go; https://github.com/DjangoGirls/djangogirls/blob/main/applications/forms.py#L40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.